This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($location): dont throw while parsing invalid URLs #9972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkozlowski-opensource
force-pushed
the
issue6836
branch
from
8e285d0 to
8de5e13
Compare
|
Hmm, looks like there is a separate code-path for IE, need to look into some more. Atm I'm not sure it is fixable in the way that things would work on all browsers... Sight... Closing for now, will re-open if I can think of a cross-browser fix... |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6836
Not a critical one but a patch is minimal and someone reported it, so why not...